-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add create-react-admin #8833
Add create-react-admin #8833
Conversation
Could you add a screencast of the current UI? Also, tests fail. |
With the new create-react-admin we can also consider deprecate the create-react-app in the documentation, because even facebook is no longer promoting using this to bootstrap a new project on the new react.dev website . |
Indeed, even though that's not related at all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems good, and I learned some tricks with it so thanks! 🙂
Could you add a Readme
though, and a makefile
target to build it?
return {}; | ||
}; | ||
|
||
const initializeProjectDirectory = (projectName: string) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should support projectName
being an absolute path.
E.g. I tried with projectName='~/workspaces/my-test-admin'
and it failed with
Error: ENOENT: no such file or directory, mkdir '/home/user/workspaces/react-admin/packages/create-react-admin/home/user/workspaces/my-test-admin'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to have. V2 imo
I have a warning in the console after completing the wizard:
It seems to be located in the (cli) |
packages/create-react-admin/templates/ra-data-json-server/dataProvider.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! This really streamlines the developer onboarding.
packages/create-react-admin/templates/common/public/manifest.json
Outdated
Show resolved
Hide resolved
packages/create-react-admin/templates/common/public/favicon.ico
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Kudos, that's a great feature!
Problem
It can be long and confusing to start a new react-admin project.
Solution
A CLI that bootstrap a project after asking what dataProvider, authProvider and resources should be added.
This PR introduces a first basic version of this tool.
Tasks
create-admin-app-fakerest.webm
create-admin-app-json.webm