Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix hook naming (use 'beforeSave') #8769

Merged
merged 2 commits into from
Mar 26, 2023
Merged

Conversation

afilp
Copy link
Contributor

@afilp afilp commented Mar 26, 2023

No description provided.

@afilp
Copy link
Contributor Author

afilp commented Mar 26, 2023

Please note that I found this code in the docs, this is why I proposed the PR. But I do not see it in the actual code now, so maybe the other doc is wrong?

{
        resource: "comments",
        beforeRead: async (data, dataProvider) => { /* ... */ },
        afterCreate: async (result, dataProvider) => { /* ... */ },
    },

@afilp afilp changed the title Add missing 'beforeRead' to docs Fix hook in docs to proper naming ('beforeSave') Mar 26, 2023
@afilp
Copy link
Contributor Author

afilp commented Mar 26, 2023

ok, I added a new commit with the other change instead.

@afilp afilp changed the title Fix hook in docs to proper naming ('beforeSave') [Doc] Fix hook naming (use 'beforeSave') Mar 26, 2023
@fzaninotto fzaninotto merged commit 84f7d2b into marmelab:master Mar 26, 2023
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 4.9.1 milestone Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants