Allow to customize how <FilterListItem> applies filters
#8676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem There is now easy way to implement cumulative filters (filtering by multiple tags for instance) without reimplementing `<FilterListItem>`. ### Solution Introduce two new props: - isSelected: accept the item value and the current filters and return a boolean - toggleFilter: accept the item value and the current filters and return new filters
fzaninotto
approved these changes
Feb 23, 2023
fzaninotto
requested changes
Feb 23, 2023
slax57
requested changes
Feb 23, 2023
packages/ra-ui-materialui/src/list/filter/FilterListItem.spec.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/list/filter/FilterListItem.spec.tsx
Outdated
Show resolved
Hide resolved
packages/ra-ui-materialui/src/list/filter/FilterListItem.spec.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Jean-Baptiste Kaiser <[email protected]>
slax57
approved these changes
Feb 23, 2023
slax57
approved these changes
Feb 24, 2023
|
Thank you so much Gildas! This will help a ton. |
|
Hey @djhi is there a reason that this is in the 4.9 milestone and not being merged into one of the more recent releases? |
|
Yes: we follow semver.
This change was merged after the latest minor (4.8.0), so it's scheduled for the next minor (4.9.0). |
|
Thanks @fzaninotto! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is now easy way to implement cumulative filters (filtering by multiple tags for instance) without reimplementing
<FilterListItem>.Solution
Introduce two new props:
TODO