Make List children responsible of the empty state #8585
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently the
<List>
component is responsible for displaying something when there is no data. However, we introduced theempty
prop on the<Datagrid>
component as well. When passingempty={false}
to the<List>
, it displays its child and theempty
provided to the<Datagrid>
is then used.However, the
<Pagination>
component also displays something special when there is no data, which is not desirable in this case.Solution
Make handling empty state the responsibility of the
<List>
child when the<List>
doesn't. Both the<Datagrid>
and the<SimpleList>
now accept anempty
prop. This prop accepts either an element orfalse
.Besides, we deprecated the
limit
prop on the<Pagination>
component. It now rendersnull
when there is no data.