Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix useReferenceInputController to pass meta to useReference #8477

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Fix useReferenceInputController to pass meta to useReference #8477

merged 1 commit into from
Dec 8, 2022

Conversation

stesie
Copy link
Contributor

@stesie stesie commented Dec 7, 2022

This relates to #8191, reporting that meta isn't passed on with ReferenceInput. The issue mentions useGetList only, however it also uses useReference (which in turn calls getMany on the data provider).

So #8192 changed ReferenceInput to pass meta to the getList call. However still not using it with the getMany call which is triggered to resolve an already assigned value.

slax57
slax57 reviewed Dec 8, 2022
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise your fix seems good, thanks!

packages/ra-core/src/controller/input/useReferenceInputController.ts Show resolved Hide resolved
@slax57 slax57 added this to the 4.6.1 milestone Dec 8, 2022
@slax57 slax57 merged commit 47d4307 into marmelab:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@stesie @slax57