Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix typo typo in Create chapter mentioning the <TextInput multiline> prop #8290

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

thdk
Copy link
Contributor

@thdk thdk commented Oct 24, 2022

The TextInput component expects the multiline prop to be lowercase while the Create docs have it written as 'multiLine`.

@fzaninotto
Copy link
Member

Thanks for taking the time to fix this!

@fzaninotto fzaninotto added this to the 4.5.0 milestone Oct 24, 2022
@fzaninotto fzaninotto changed the title Docs: fix small typo in Create.md [Doc] Fix typo typo in Create for mentioning the <TextInput multiline> prop Oct 24, 2022
@fzaninotto fzaninotto changed the title [Doc] Fix typo typo in Create for mentioning the <TextInput multiline> prop [Doc] Fix typo typo in Create chapter mentioning the <TextInput multiline> prop Oct 24, 2022
@thdk
Copy link
Contributor Author

thdk commented Oct 24, 2022

Thanks for taking the time to fix this!

You are welcome! :)

Just a question, should PRs be created for the next / master branch?

@fzaninotto
Copy link
Member

From the master branch for bug fixes, and from the next branch for new features. See https://github.com/marmelab/react-admin#contributing

@thdk
Copy link
Contributor Author

thdk commented Oct 24, 2022

Ah, I started reading the docs a bit lower

Pull requests for bug fixes are welcome on the GitHub repository. There is always a bunch of issues labeled "Good First Issue" in the bug tracker - start with these.

If you want to add a feature, you can open a Pull request on the next branch.

My mistake in reading that only at a glance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants