-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AutocompleteInput input's value not updating correctly #8238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides, it would be nice if you could add some tests to cover this case in the future 🙂
I'm afraid the fix is still incomplete. There are still cases where you cannot use backspace, for example in the I think the problem actually comes from this function: const handleInputChange = (
event: any,
newInputValue: string,
reason: string
) => {
if (!doesQueryMatchSelection(newInputValue, event?.type)) {
setFilterValue(newInputValue);
debouncedSetFilter(newInputValue);
}
}; The Besides, the unit test In the end, I'm not sure we need to change the |
Great! thanks for your review! 👍 |
e8ccb54
to
4e15ed1
Compare
Fixes #8227