Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: FormTab not turning red after ArrayInput global validation error #8198

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

thibault-barrat
Copy link
Contributor

@thibault-barrat thibault-barrat commented Sep 26, 2022

Fixes #8190

Enregistrement.de.l.ecran.2022-09-26.a.13.16.18.mov

image

@thibault-barrat thibault-barrat added the RFR Ready For Review label Sep 26, 2022
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems fine. Could you please add a story and a unit test for the fix?

@thibault-barrat
Copy link
Contributor Author

The code seems fine. Could you please add a story and a unit test for the fix?

I added the story and the test

@slax57 slax57 added this to the 4.4.0 milestone Sep 27, 2022
@slax57 slax57 merged commit f77be17 into master Sep 27, 2022
@slax57 slax57 deleted the fix-array-input-error-formtab branch September 27, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormTab not turning red after ArrayInput global validation error
5 participants