add "expand_all" toggle to datagrid header

[hiaselhans]

this adds a "collapse all" Button in the DataGridHeader

Behavior:

• if one or more rows are expanded, the CollapseButton shows an opened state.
  • onClick collapses all shown rows
• if all rows are collapsed onClick all rows are expanded

[hiaselhans]

demo: storybook

[fzaninotto]

Awesome! Thanks for that.

Would you mind adding a unit test based on the storybook?

[hiaselhans]

thanks @fzaninotto !

I added the tests to cypress.
Hope that works, not sure how to add tests to the storybook...

[fzaninotto]

For the tests, please write a react-testing-library test rather than an e2e test. You can leverage the Storybook as we did e.g. in https://github.com/marmelab/react-admin/blob/master/packages/ra-ui-materialui/src/field/ReferenceOneField.spec.tsx

[hiaselhans]

ok, so i added expandAllButton.spec.tsx with best intentions. Hope that works now.
I would still not remove the e2e test, maybe it proves useful at some point

[slax57]

Otherwise this looks good, thanks! 🙂

[hiaselhans]

done! Thanks

[slax57]

Thanks!
I'll give some time to @fzaninotto if he wants to re-review it, then we'll be able to merge 🙂

[fzaninotto]

these are the notDisplayedExpandedIds, right?

[hiaselhans]

as a compromise, i'd say unaffectedExpandedIds, since in this context we don't have displayed or hidden ids 👿

[fzaninotto]

Why this tabindex?

[hiaselhans]

dito

[hiaselhans]

since ExpandRowButtons are not tab-selectable, the least i would do here is to stay consistent and keep tabindex = -1.

[fzaninotto]

I don't understand this "unaffected".

[hiaselhans]

possible synonyms:

• unChanged
• unAltered
• unTouched

[fzaninotto]

Thanks!

[hiaselhans]

thanks! and keep up the good work! :)