Add support for getLocales in Polyglot i18nProvider #8143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
changed the title
WiXSL
suggested changes
Sep 6, 2022
| */ | ||
| export default ( | ||
| getMessages: GetMessages, | ||
| initialLocale: string = 'en', | ||
| availableLocales: Locale[] = [{ locale: 'en', name: 'English' }], | ||
| polyglotOptions: any = {} | ||
| ): I18nProvider => { | ||
| let locale = initialLocale; |
There was a problem hiding this comment.
Shouldn't we throw a warning if the initialLocal is not in the availableLocales? Maybe I'm nitpicking here
WiXSL
suggested changes
Sep 6, 2022
There was a problem hiding this comment.
TranslationSetup.md - line 152:
The specified anchor using-specific-polyglot-features is in the README of polyglot package, not above in the document.
This solution is all-or-nothing: you can't silence only some missing translation warnings. An alternative solution consists of passing a default translation using the _ translation option, as explained in the Using Specific Polyglot Features section(#using-specific-polyglot-features) above.
Co-authored-by: Gildas Garcia <[email protected]>
djhi
approved these changes
Sep 8, 2022
slax57
approved these changes
Sep 8, 2022
WiXSL
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #7758