Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a custom filter property in useList #8116

Merged
merged 4 commits into from
Sep 1, 2022
Merged

Add a custom filter property in useList #8116

merged 4 commits into from
Sep 1, 2022

Conversation

ogustavo-pereira
Copy link
Contributor

I tried to make the adjustment to be able to meet this feature #7970

Any suggestion or consideration for making a change just let me know!

Requirements

  • Allow a callback to perform filters on the view ✅
  • Test ✅
  • Docs ✅

WiXSL
WiXSL suggested changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@WiXSL WiXSL left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!
We would like if you could change the name of the method from setCustomFilter to filterCallback
Other than that, it seems ok

@WiXSL WiXSL added the RFR Ready For Review label Aug 30, 2022
@ogustavo-pereira
Copy link
Contributor Author

Adjusted according to comment #8116 (review)

Commit ce15352

@fzaninotto fzaninotto merged commit 2cc655b into marmelab:next Sep 1, 2022
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 4.4.0 milestone Sep 1, 2022
@fzaninotto fzaninotto mentioned this pull request Sep 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@WiXSL WiXSL Awaiting requested review from WiXSL

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ogustavo-pereira @fzaninotto @WiXSL