-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to set custom routes as Resource children #8079
Conversation
Thanks! Thats an interesting feature. As it's an enhancement, please rebase your PR against the Also, please document that feature and add some unit tests to make sure it works. |
a7fbf7c
to
2d60a78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work!
You are still missing some test to prove that it works.
dc0c4c1
to
b0f26e9
Compare
thx @WiXSL ! i fixed the comments and added a test. |
Thanks! |
Great, thank you! |
React admin makes it fast to develop admin-interfaces with react.
However, when resources get more and more functions it is a bit unhandy to pass CustomRoutes to
This PR adds children as a property of resources and makes it possible to define the whole resource with custom sub-routes in a seperate typescript module: