Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Add label prop for <ReferenceInput> and <ReferenceArrayInput> in docs #8068

Merged
merged 5 commits into from
Aug 12, 2022
Merged

[Doc] Add label prop for <ReferenceInput> and <ReferenceArrayInput> in docs #8068

merged 5 commits into from
Aug 12, 2022

Conversation

thibault-barrat
Copy link
Contributor

@thibault-barrat thibault-barrat commented Aug 12, 2022 •
edited
Loading

  • Fix doc mentionning that ReferenceInput does not need the "label" prop

@thibault-barrat thibault-barrat added the RFR Ready For Review label Aug 12, 2022
@thibault-barrat thibault-barrat changed the title [Doc] Add labelprop for <ReferenceInput> and <ReferenceArrayInput>in docs and add resettable prop in SelectInputProps` [Doc] Add label prop for <ReferenceInput> and <ReferenceArrayInput> in docs and add resettable prop in SelectInputProps Aug 12, 2022
@thibault-barrat thibault-barrat changed the title [Doc] Add label prop for <ReferenceInput> and <ReferenceArrayInput> in docs and add resettable prop in SelectInputProps [Doc] Add label prop for <ReferenceInput> and <ReferenceArrayInput> in docs and add resettable prop in SelectInputProps type Aug 12, 2022
slax57
slax57 requested changes Aug 12, 2022
View reviewed changes
docs/ReferenceArrayInput.md Outdated Show resolved Hide resolved
docs/ReferenceInput.md Outdated Show resolved Hide resolved
docs/Upgrade.md Outdated Show resolved Hide resolved
@thibault-barrat thibault-barrat changed the title [Doc] Add label prop for <ReferenceInput> and <ReferenceArrayInput> in docs and add resettable prop in SelectInputProps type [Doc] Add label prop for <ReferenceInput> and <ReferenceArrayInput> in docs Aug 12, 2022
slax57
slax57 approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice!

@antoinefricker antoinefricker added this to the 4.2.8 milestone Aug 12, 2022
@antoinefricker antoinefricker merged commit 2fe32c4 into master Aug 12, 2022
@antoinefricker antoinefricker deleted the doc-ts-improvements branch August 12, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoinefricker antoinefricker antoinefricker approved these changes

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.2.8
Development

Successfully merging this pull request may close these issues.
3 participants
@thibault-barrat @slax57 @antoinefricker