Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FormDataConsumer inside SimpleFormIterator adds empty value #8061

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Fix FormDataConsumer inside SimpleFormIterator adds empty value #8061

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efbdeaf
Fix FormDataConsumer inside SimpleFormIterator adds empty value
fzaninotto Aug 10, 2022
f55af51
Add unit test
fzaninotto Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/ra-ui-materialui/src/input/ArrayInput/SimpleFormIterator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { styled } from '@mui/material';
import clsx from 'clsx';
import get from 'lodash/get';
import PropTypes from 'prop-types';
import { RaRecord, useRecordContext } from 'ra-core';
import { FormDataConsumer, RaRecord, useRecordContext } from 'ra-core';
import { UseFieldArrayReturn } from 'react-hook-form';

import { useArrayInput } from './useArrayInput';
Expand Down Expand Up @@ -61,7 +61,10 @@ export const SimpleFormIterator = (props: SimpleFormIteratorProps) => {
if (item == null) {
defaultValue = {} as Record<string, unknown>;
Children.forEach(children, input => {
if (React.isValidElement(input)) {
if (
React.isValidElement(input) &&
input.type !== FormDataConsumer
) {
defaultValue[input.props.source] =
input.props.defaultValue ?? '';
}
Expand Down