Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input label proptypes and DatagridInput imports #8019

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Input label proptypes and DatagridInput imports #8019

merged 3 commits into from
Jul 28, 2022

Conversation

megantaylor
Copy link
Contributor

  • add element to label proptypes for inputs to eliminate browser console errors when passing an element as a label
  • fix imports in DatagridInput (fixes DatagridInput imports #8018)

djhi
djhi approved these changes Jul 28, 2022
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhi djhi added this to the 4.2.5 milestone Jul 28, 2022
@djhi djhi merged commit 91c3d5e into marmelab:master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2.5
Development

Successfully merging this pull request may close these issues.

DatagridInput imports
2 participants
@megantaylor @djhi