Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <Menu> storybook is missing #7776

Merged
merged 6 commits into from
Jun 3, 2022
Merged

Fix <Menu> storybook is missing #7776

merged 6 commits into from
Jun 3, 2022

Conversation

antoinefricker
Copy link
Contributor

@antoinefricker antoinefricker commented Jun 2, 2022

A step towards complete visual testing through storybook cases.

Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little description about why you need to add this Storybook and what you want to use it for would be welcome 🙂

packages/ra-ui-materialui/src/layout/Menu.stories.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/layout/Menu.stories.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/layout/Menu.stories.tsx Outdated Show resolved Hide resolved
return <Menu hasDashboard={true} dense={true} />;
};

const StorybookAppBar = props => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why you customize the AppBar in this Story

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to provide dark/default theme testing ability. Should I remove it?

@vercel vercel bot temporarily deployed to Preview – react-admin June 3, 2022 07:35 Inactive
@fzaninotto fzaninotto merged commit e9a17f6 into master Jun 3, 2022
@fzaninotto fzaninotto deleted the menu-storybook branch June 3, 2022 12:49
@fzaninotto fzaninotto added this to the 4.1.3 milestone Jun 3, 2022
@fzaninotto fzaninotto changed the title Add a storybook case for Menu Fix <Menu> storybook is missing Jun 3, 2022
Seojun-Park pushed a commit to Seojun-Park/react-admin that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants