Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ShowBase, CreateBase and EditBase components support resource override via props #7652

Merged
merged 5 commits into from
May 11, 2022
Merged

Make ShowBase, CreateBase and EditBase components support resource override via props #7652

merged 5 commits into from
May 11, 2022

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented May 6, 2022

Fixes #7651

@slax57 slax57 added the RFR Ready For Review label May 6, 2022
@vercel vercel bot temporarily deployed to Preview – react-admin May 6, 2022 11:41 Inactive
djhi
djhi approved these changes May 6, 2022
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that Create, Edit and Show can probably use their base counter part now

@vercel vercel bot temporarily deployed to Preview – react-admin May 6, 2022 13:25 Inactive
@djhi djhi added this to the 4.0.4 milestone May 6, 2022
@vercel vercel bot temporarily deployed to Preview – react-admin May 6, 2022 14:16 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin May 11, 2022 08:24 Inactive
@fzaninotto fzaninotto merged commit c3d490e into master May 11, 2022
@fzaninotto fzaninotto deleted the 7651-createbase-doesnt-set-the-resourcecontext-like-create-does branch May 11, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.0.4
Development

Successfully merging this pull request may close these issues.

CreateBase doesn't set the ResourceContext like Create does
3 participants
@slax57 @fzaninotto @djhi