Avoid cloning elements in forms #7223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Feb 10, 2022
| @@ -818,30 +818,34 @@ export const PostCreate = () => ( | |||
|
|
|||
| ### Label Decoration | |||
|
|
|||
| `<SimpleForm>` scans its children for the `addLabel` prop, and automatically wraps a child in a `<Labeled>` component when found. This displays a label on top of the child, based on the `label` prop. This is not necessary for `<Input>` components, as they already contain their label. Also, all the react-admin `<Field>` components have a default prop `addLabel: true`, which explains why react-admin shows a label on top of Fields when they are used as children of `<SimpleForm>`. | |||
| All react-admin inputs handle the display of their label by wrapping their content inside a `<Labeled>` component. | |||
There was a problem hiding this comment.
that's not true for Inputs. Fields, maybe?
There was a problem hiding this comment.
It is actually true for many inputs (ArrayInput, CheckboxGroupInput, FileInput, RadioButtonGroupInput, SelectArrayInput and SelectInput). The others uses MUI default label
| @@ -969,31 +973,37 @@ export const PostEdit = () => ( | |||
|
|
|||
| ### Label Decoration | |||
|
|
|||
| `<FormTab>` scans its children for the `addLabel` prop, and automatically wraps a child in a `<Labeled>` component when found. This displays a label on top of the child, based on the `label` prop. This is not necessary for `<Input>` components, as they already contain their label. Also, all the react-admin `<Field>` components have a default prop `addLabel: true`, which explains why react-admin shows a label on top of Fields when they are used as children of `<FormTab>`. | |||
| All react-admin inputs handle the display of their label by wrapping their content inside a `<Labeled>` component. | |||
There was a problem hiding this comment.
why is this content repeated?
There was a problem hiding this comment.
We have this section inside the SimpleForm and the TabbedForm sections
fzaninotto
reviewed
Feb 10, 2022
Closed
djhi
force-pushed
the
avoid-cloning-forms
branch
from
9ec83bd
to
8e07058
Compare
WiXSL
suggested changes
Feb 15, 2022
WiXSL
suggested changes
Feb 15, 2022
WiXSL
reviewed
Feb 15, 2022
|
|
||
| This is no longer the case and makes custom layout easier. | ||
|
|
||
| ### `<SimpleForm>` and `<TabbedForm>` No Longer Clone Their Children |
There was a problem hiding this comment.
Once again, this is wonderful! 💪
WiXSL
suggested changes
Feb 15, 2022
WiXSL
suggested changes
Feb 15, 2022
WiXSL
suggested changes
Feb 15, 2022
WiXSL
suggested changes
Feb 15, 2022
WiXSL
suggested changes
Feb 15, 2022
WiXSL
suggested changes
Feb 15, 2022
WiXSL
suggested changes
Feb 15, 2022
WiXSL
suggested changes
Feb 15, 2022
WiXSL
suggested changes
Feb 15, 2022
added 10 commits
February 15, 2022 17:33
djhi
force-pushed
the
avoid-cloning-forms
branch
from
5236bc9
to
8090730
Compare
WiXSL
suggested changes
Feb 15, 2022
fzaninotto
requested changes
Feb 16, 2022
fzaninotto
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR, I'll make a few others to ensure that every inputs handle the
fullWidthproperty correctly. I'll also add stories for each input.