Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a bug at
resolveBrowserLocale
tests during #7170 investigation to implement a new feature (#7193).Problem:
As
navigator.language
is a read-only property (see MDN page about it), it wasn't being affected by thewindow.navigator = {}
. You can see that atshould return default locale if there's no available locale in browser
test, it is an invalid test.Solution:
Implement correctly using
jest.spyOn
function, see this answer: https://stackoverflow.com/a/52870312Should this fix enter before #7193 @WiXSL ?