Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BC Break] Retire redux #7177

Merged
merged 9 commits into from
Feb 3, 2022
Merged

[BC Break] Retire redux #7177

merged 9 commits into from
Feb 3, 2022

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Feb 2, 2022 •
edited
Loading

  • Remove <Admin customReducers>
  • Remove <Admin initialState>
  • Do not create a Redux <Provider> in <Admin>
  • Remove dependencies on redux and react-redux packages
  • Make sure tests and demos still work
  • Fix doc
  • Add changelog

@fzaninotto fzaninotto added the RFR Ready For Review label Feb 2, 2022
@fzaninotto fzaninotto added this to the 4.0.0-alpha.3 milestone Feb 2, 2022
@fzaninotto
Copy link
Member Author

I'm surprised that the build of the e-commerce demo doesn't change much:

File sizes after gzip:

  607.9 kB (-1.69 kB)  build/static/js/main.886b6121.js
  85.79 kB             build/static/js/327.3776b9a6.chunk.js
  67.96 kB             build/static/js/775.729f778c.chunk.js
  58.95 kB             build/static/js/250.42aa2365.chunk.js
  12.43 kB             build/static/js/292.eea62de7.chunk.js
  5.73 kB (+1 B)       build/static/js/908.0296630d.chunk.js
  3.95 kB              build/static/js/376.72118f7b.chunk.js
  3.73 kB              build/static/js/477.84064d46.chunk.js
  3.61 kB              build/static/js/247.4f700bc0.chunk.js
  1.43 kB (+1 B)       build/static/js/151.cf8ab998.chunk.js

While bundlephobia tells me that react-redux alone weighs 5,4 kB.

@fzaninotto fzaninotto mentioned this pull request Feb 2, 2022
Closed
WiXSL
WiXSL reviewed Feb 2, 2022
View reviewed changes
Copy link
Contributor

@WiXSL WiXSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still a dependency to "@types/react-redux": "^7.1.1", in the main react-admin/package.json, I don't know if it's necessary

@vercel vercel bot temporarily deployed to Preview – react-admin February 2, 2022 20:14 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin February 3, 2022 08:07 Inactive
djhi
djhi requested changes Feb 3, 2022
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an eslint warning left

UPGRADE.md Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
@fzaninotto fzaninotto changed the title [BC Break] Remove redux [BC Break] Retire redux Feb 3, 2022
@vercel vercel bot temporarily deployed to Preview – react-admin February 3, 2022 08:47 Inactive
@djhi djhi merged commit 21e5a9b into next Feb 3, 2022
@djhi djhi deleted the remove-redux branch February 3, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WiXSL WiXSL WiXSL left review comments

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@fzaninotto @djhi @WiXSL