Replace Quill RichTextInput With TipTap RichTextInput #7153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
changed the title
|
needs rebase |
fzaninotto
requested changes
Jan 28, 2022
| @@ -22,7 +22,7 @@ | |||
| "run-graphql-demo-watch": "concurrently \"yarn run watch\" \"yarn run run-graphql-demo\"", | |||
| "run-crm": "cd examples/crm && yarn start", | |||
| "build-crm": "cd examples/crm && yarn build", | |||
| "storybook": "start-storybook -p 9009", | |||
| "storybook": "start-storybook -p 9010", | |||
There was a problem hiding this comment.
Had a known issue with storybook only returning 404. Changing the port solved it
| @@ -1,79 +1,141 @@ | |||
| # `<RichTextInput>` for react-admin | |||
| # ra-richtext-tiptap | |||
There was a problem hiding this comment.
that's not the name of the package
|
|
||
| ## Installation | ||
|
|
||
| ```sh | ||
| npm install ra-input-rich-text --save-dev | ||
| npm install ra-richtext-tiptap |
| return <span>Post {record ? `"${record.title}"` : ''}</span>; | ||
| }; | ||
| import { Edit, SimpleForm, TextInput } from 'react-admin'; | ||
| import { RichTextInput } from 'ra-richtext-tiptap'; |
| HorizontalRule, | ||
| ], | ||
| }; | ||
| ``` |
There was a problem hiding this comment.
Added. We have several packages without this section btw
| @@ -45,6 +45,22 @@ export const defaultTheme = { | |||
| opacity: 0.3, | |||
| borderRadius: 'inherit', | |||
| }, | |||
| '&:focus::after': { | |||
There was a problem hiding this comment.
Can you elaborate why you need that?
WiXSL
reviewed
Jan 28, 2022
WiXSL
suggested changes
Jan 28, 2022
Co-authored-by: Aníbal Svarcas <[email protected]>
WiXSL
suggested changes
Jan 28, 2022
fzaninotto
approved these changes
Jan 28, 2022
WiXSL
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Our old
RichTextInputwas based on Quill but:The solution
The new
RichTextInputuses TipTap, a UI less library to build rich text editors. It gives us the freedom to implement the UI how we want with MUI components. That solves all the above issuesTasks