Migrate AutocompleteArrayInput to MUI Autocomplete #6971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
djhi
commented
Dec 10, 2021
•
djhi
commented
- Implementation
- Tests
- Stories
- Documentation
- Upgrade guide
- Refactor
- Remove options prop
|
The storybook isn't deployed by Vercel, is it normal? |
fzaninotto
requested changes
Dec 16, 2021
docs/Inputs.md
Outdated
| @@ -647,7 +647,7 @@ If you want to limit the initial choices shown to the current value only, you ca | |||
| When dealing with a large amount of `choices` you may need to limit the number of suggestions that are rendered in order to maintain usable performance. The `shouldRenderSuggestions` is an optional prop that allows you to set conditions on when to render suggestions. An easy way to improve performance would be to skip rendering until the user has entered 2 or 3 characters in the search box. This lowers the result set significantly, and might be all you need (depending on your data set). | |||
| Ex. `<AutocompleteInput shouldRenderSuggestions={(val) => { return val.trim().length > 2 }} />` would not render any suggestions until the 3rd character has been entered. This prop is passed to the underlying `react-autosuggest` component and is documented [here](https://github.com/moroshko/react-autosuggest#should-render-suggestions-prop). | |||
|
|
|||
| `<AutocompleteInput>` renders a [material-ui `<TextField>` component](https://material-ui.com/api/text-field/). Use the `options` attribute to override any of the `<TextField>` attributes: | |||
| `<AutocompleteInput>` renders a [material-ui `<Autocomplete>` component](https://mui.com/components/autocomplete/). Use the `options` attribute to override any of the `<Autocomplete>` attributes: | |||
There was a problem hiding this comment.
I thought you removed that possibility
| useSupportCreateSuggestion, | ||
| } from './useSupportCreateSuggestion'; | ||
|
|
||
| /** |
There was a problem hiding this comment.
I think you should keep some jsDoc, at least to explain that it's deprecated
packages/ra-ui-materialui/src/input/useSupportCreateSuggestion.tsx
Outdated
Show resolved
Hide resolved
| @@ -407,10 +457,74 @@ If you provided a React element for the optionText prop, you must also provide t | |||
| ); | |||
| }; | |||
|
|
|||
| export interface AutocompleteInputProps | |||
| extends ChoicesInputProps<AutocompleteProps<any, false, false, false>>, | |||
| // @ts-ignore | |||
WiXSL
suggested changes
Dec 16, 2021
| }, | ||
| })); | ||
| export const AutocompleteArrayInput = props => ( | ||
| <AutocompleteInput multiple {...props} /> |
There was a problem hiding this comment.
Suggested change
| <AutocompleteInput multiple {...props} /> | |
| <AutocompleteInput {...props} multiple /> |
Closed
fzaninotto
requested changes
Jan 3, 2022
added 15 commits
January 3, 2022 13:55
djhi
force-pushed
the
mui-autocomplete-array
branch
from
66268f8
to
1ef0bf6
Compare
fzaninotto
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.