Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tab component children missing fullWidth prop when addLabel was set #6915

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Fix Tab component children missing fullWidth prop when addLabel was set #6915

merged 1 commit into from
Nov 29, 2021

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Nov 29, 2021

Fixes #6674

Before:

before

After:

after

@djhi
Copy link
Collaborator

djhi commented Nov 29, 2021

I think it shouldn't change the container width

@WiXSL
Copy link
Contributor Author

WiXSL commented Nov 29, 2021

I think it shouldn't change the container width

Do you mean the width of the Labeled component?
Is the same change than in SimpleShowLayout

@djhi
Copy link
Collaborator

djhi commented Nov 29, 2021

Nevermind, that's just the screenshot size that is not the same in both

@djhi djhi merged commit b10853b into master Nov 29, 2021
@djhi djhi deleted the fix-fullwidth-tab branch November 29, 2021 11:37
@djhi djhi added this to the 3.19.3 milestone Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.19.3
Development

Successfully merging this pull request may close these issues.

ReferenceManyField fullWidth only works when addLabel={false}
2 participants
@WiXSL @djhi