override useShowController onFailure behavior and return error object

[panfiva]

See #5197

[djhi]

Hi and thanks for taking the time to open a PR!

Although adding the onFailure is ok, it's a new feature so your PR should target the next branch. However, please revert the addition of the error returned by useGetOne and useShowController. Indeed, overriding the onFailure should be enough as it will called with the error as its first argument even though we don't use it in our default handler.

Finally, can you please revert unrelated changes in the documentation?

Thanks!

[panfiva]

@djhi ,

The reason i added "error" property is to be able to support the following usecase:

const showController = useShowController<T>({
    resource,  basePath, id,     
    onFailure: () => {}, // prevent redirect to list and user notification on errors
  })

const { loaded, record, error } = showController

if (error) return <Error error={error} />
else if (loaded) return <Render record={record} />
else return <Loading />

This way, I do not have to create custom onFailure function that uses useState to render <Error> component

[panfiva]

@djhi ,

can we commit with error, since it is a very useful feature to have?

[djhi]

@panfiva We discussed it and we agree it is a good idea so thank you for bringing that up! However, there are two other places where this would make sense as well: useEditController for the getOne operation and useListController for its getList. Would you mind adding support for error in those as well? Thanks!

[panfiva]

I can add support there as well. Would you like me to update the current pull request, or create a separate pull request?

[djhi]

Thanks! You can do that in the same PR if you want.

[djhi]

Thanks for starting the work on this! I finished it in another PR as we want to release 3.19