Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply review on useList #6378

Merged
merged 3 commits into from
Jun 22, 2021
Merged

Apply review on useList #6378

merged 3 commits into from
Jun 22, 2021

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Jun 22, 2021

Follows #6321

Applied the the following adjustments:

  • Remove the ids and data params - they don't make sens in that context
  • remove the 'initial' prefix in all arguments.
  • update JSDoc accordingly

This should allow a simpler call, like:

 const listContext = useList({
    data,
    ids,
    filter: { is_published: truev},
    sort: { field: 'title', order: 'ASC' },
    page: 1,
    perPage: 10,
    basePath: '/resource';
    resource: 'resource';
 });

@djhi djhi added the RFR Ready For Review label Jun 22, 2021
@djhi djhi added this to the 3.17.0 milestone Jun 22, 2021
packages/ra-core/src/controller/useList.ts Outdated Show resolved Hide resolved
packages/ra-core/src/controller/useList.ts Outdated Show resolved Hide resolved
@fzaninotto fzaninotto merged commit 82a46fc into next Jun 22, 2021
@fzaninotto fzaninotto deleted the use-list-review branch June 22, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants