-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Offer logout option in auth provider #6326
Feature: Offer logout option in auth provider #6326
Conversation
@djhi @fzaninotto hey folks! wondering if there's any update for this ticket? It's good for a review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I've resolved the requested changes, @djhi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I'd like to get a Cypress test added for this behaviour, but can't figure out an appropriate way to do it. Is there a way to monkey patch in a slightly modified authProvider? If not, I could:
I added a unit test, but it didn't catch the problem when I called What do you guys think? Other than that, i've resolved the rest of the comments |
Note: I added a notification if a user was redirected but not logged out. I added a french translation that was made via google translate, since I don't speak French! Please let me know what you'd like the message to be 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Thanks a lot! |
Closes: #5882
Handles additional options to the
checkError
'sPromise.reject
.redirect-on-error.mov
Notes:
useLogoutIfAccessDenied
, since it can now sometimes not log the user out if access is denied.useLogout
.