Migrate Simple example To Vite Instead Of Webpack For Faster Development #5857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
force-pushed
the
simple-example-vite
branch
from
6db6668
to
9131725
Compare
fzaninotto
requested changes
Feb 4, 2021
|
Needs rebase |
djhi
force-pushed
the
simple-example-vite
branch
from
2b194db
to
bcd73ae
Compare
fzaninotto
requested changes
Feb 16, 2021
| </head> | ||
| <body> | ||
| <div id="root"></div> | ||
| <script>window.global = window</script> |
There was a problem hiding this comment.
why do we need this for webpack?
There was a problem hiding this comment.
This is needed for one of our dependency, can't remember which one though. Not related to webpack
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> |
There was a problem hiding this comment.
Because the old values didn't provide any value AFAIK. Besides, minimum-scale can be an accessibility issue for browsers that still respect them (those I use don't actually)
fzaninotto
approved these changes
Feb 16, 2021
fzaninotto
changed the title
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds up development dramatically. However, this won't work until we release the next version of Fakerest using modern bundlers (PR incoming)