Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BC Break] Move test utils outside of ra-core #5846

Merged
merged 8 commits into from
Feb 2, 2021
Merged

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Feb 1, 2021

Closes #4618

This is a slight BC break in development: any import of the Test utils from "ra-core" will fail and must be replaced by an import from "ra-test".

-import { renderHook, useMatchingReferences} from 'react-admin';
+import { useMatchingReferences} from 'react-admin';
+import { renderHook } from 'ra-test';

@djhi djhi added the RFR Ready For Review label Feb 1, 2021
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be PRed against the next branch

packages/ra-test/package.json Show resolved Hide resolved
@djhi djhi changed the base branch from master to next February 2, 2021 11:22
"final-form": "^4.20.0",
"history": "^4.7.2",
"ignore-styles": "~5.0.1",
"ra-core": "^3.12.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a peerDependency, to avoid circular dependencies.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in both dev and peer dependencies

packages/ra-test/README.md Outdated Show resolved Hide resolved
packages/ra-test/README.md Outdated Show resolved Hide resolved
packages/ra-test/README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants