-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BC Break] Move test utils outside of ra-core #5846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This must be PRed against the next
branch
34313b2
to
fd77e3f
Compare
"final-form": "^4.20.0", | ||
"history": "^4.7.2", | ||
"ignore-styles": "~5.0.1", | ||
"ra-core": "^3.12.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be a peerDependency, to avoid circular dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in both dev and peer dependencies
Co-authored-by: Francois Zaninotto <[email protected]>
Closes #4618
This is a slight BC break in development: any import of the Test utils from "ra-core" will fail and must be replaced by an import from "ra-test".