Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Demo] Fix double spinner on loading and TS warnings #5790

Merged
merged 2 commits into from
Jan 18, 2021
Merged

[Demo] Fix double spinner on loading and TS warnings #5790

merged 2 commits into from
Jan 18, 2021

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Jan 17, 2021 •
edited
Loading

Problems

Upon loading, the e-commerce demo shows two spinners in a row:

  • once before the React app mounts (the spinner is in index.html)
  • once before the dataProvider loads (the spinner is in App.tsx)

This feels buggy, and delays the first meaningful paint of the Demo by a few microseconds.

Also, the demo shows ts warnings on startup.

Solution

  • Load the dataProvider before mounting the React app
  • Upgrade CRA to get latest eslint & typescript versions

@fzaninotto fzaninotto added the RFR Ready For Review label Jan 17, 2021
@djhi djhi added this to the 3.11.4 milestone Jan 18, 2021
@djhi djhi merged commit 6bf9658 into master Jan 18, 2021
@djhi djhi deleted the Fix-demo-loading branch January 18, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.11.4
Development

Successfully merging this pull request may close these issues.
2 participants
@fzaninotto @djhi