Introduce Form Groups #5752
Merged
Introduce Form Groups #5752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Jan 13, 2021
| const newState = Array.from(fields).reduce<FormGroupState>( | ||
| (acc, field) => { | ||
| const fieldState = form.getFieldState(field); | ||
| let errors = acc.errors; |
There was a problem hiding this comment.
let errors = acc.errors || []; and remove line 40 to 42
| @@ -44,7 +53,9 @@ describe('<SaveButton />', () => { | |||
| <TestContext> | |||
| <ThemeProvider theme={theme}> | |||
| <SaveContextProvider value={saveContextValue}> | |||
| <SaveButton {...invalidButtonDomProps} /> | |||
| <FormContextProvider value={formContextValue}> | |||
There was a problem hiding this comment.
I don't understand why this is now required and it worries me (that it's now required). this will be a gotcha for users.
There was a problem hiding this comment.
I actually don't get how those tests could have pass before. Indeed, the SaveButton has always been retrieving the setOnSave function from the FormContext and should have failed
| errors[field] = fieldState.error; | ||
| } | ||
|
|
||
| const newState = { |
There was a problem hiding this comment.
Please add a unit test for that logic
| export const findTabsWithErrors = (children, errors) => { | ||
| // TODO: Provide documentation link |
Co-authored-by: Francois Zaninotto <[email protected]>
fzaninotto
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing form groups will allow us to remove the restrictions on the
FormTabcontent which could accept any components and not just inputs while still tracking whether any of their inputs are invalid.