Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in comments and string literals #5739

Merged
merged 10 commits into from
Jan 6, 2021
Merged

Fix typos in comments and string literals #5739

merged 10 commits into from
Jan 6, 2021

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Jan 4, 2021

No description provided.

@WiXSL WiXSL changed the title Fix comments typos Fix typos in comments and string literals Jan 4, 2021
@WiXSL
Copy link
Contributor Author

WiXSL commented Jan 4, 2021

Ready for review

djhi
djhi requested changes Jan 6, 2021
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you revert the changes on tsconfig.json please?

@WiXSL WiXSL requested a review from djhi January 6, 2021 09:56
@fzaninotto
Copy link
Member

Tremendous work! 😍

Thanks a lot, this increases the code quality big time.

@fzaninotto fzaninotto merged commit c418566 into marmelab:master Jan 6, 2021
@fzaninotto fzaninotto added this to the 3.11.2 milestone Jan 6, 2021
@WiXSL WiXSL deleted the fix-jsdocs-typos branch January 6, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@djhi djhi Awaiting requested review from djhi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.2
Development

Successfully merging this pull request may close these issues.
3 participants
@WiXSL @fzaninotto @djhi