Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade test dependencies #5679

Merged
merged 10 commits into from
Dec 16, 2020
Merged

Upgrade test dependencies #5679

merged 10 commits into from
Dec 16, 2020

Conversation

Luwangel
Copy link
Contributor

It's been a while since these dependencies have not been upgraded.

Todo

  • Upgrade @testing-library/react to v11.2.2
  • Upgrade jest to v26.4.3
  • Upgrade ts-jest to v26.4.4
  • Remove cleanup after each test because it's now automatically done by @testing-library/react
  • Use waitFor instead of the waitForElement which is now deprecated
  • Fix all failing tests

@Luwangel Luwangel added the RFR Ready For Review label Dec 16, 2020
@Luwangel Luwangel requested a review from djhi December 16, 2020 15:47
djhi
djhi approved these changes Dec 16, 2020
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@djhi djhi merged commit e1e2b60 into next Dec 16, 2020
@djhi djhi deleted the upgrade-test-dependencies branch December 16, 2020 16:28
@djhi djhi added this to the 3.12 milestone Dec 16, 2020
@Luwangel
Copy link
Contributor Author

Luwangel commented Dec 16, 2020 •
edited
Loading

@djhi Tests failed on the CI (passed locally). I hope that it's just a false negative 🤞.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.12
Development

Successfully merging this pull request may close these issues.
2 participants
@Luwangel @djhi