Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ExportButton doesn't take permanent filter into account #5675

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Fix ExportButton doesn't take permanent filter into account #5675

merged 1 commit into from
Dec 16, 2020

Conversation

fzaninotto
Copy link
Member

Closes #5286

@fzaninotto fzaninotto added the RFR Ready For Review label Dec 15, 2020
djhi
djhi reviewed Dec 16, 2020
View reviewed changes
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many eslint warnings. I know the dependencies are refs but still.. Should I merge?

@fzaninotto
Copy link
Member Author

The eslint warnings are on unchanged files. We need to fix them, but on another PR.

@djhi djhi merged commit 6f359dc into master Dec 16, 2020
@djhi djhi deleted the fix-export-button-filter branch December 16, 2020 14:54
@djhi djhi added this to the 3.11.1 milestone Dec 16, 2020
@fzaninotto fzaninotto mentioned this pull request Dec 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.11.1
Development

Successfully merging this pull request may close these issues.

List exporter does not take into account what is in the filter prop
2 participants
@fzaninotto @djhi