Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better support for async validators #5623

Merged
merged 3 commits into from
Dec 7, 2020
Merged

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Dec 3, 2020

It's currently possible to pass an async validation function if, and only if, this is either the only validator or the last one inside the validation functions array.

This PR aims at providing real support for async validation functions.

TODO

  • Implementation
  • Tests
  • Documentation

@djhi djhi added the WIP Work In Progress label Dec 3, 2020
@fzaninotto
Copy link
Member

What's left for RFR?

@djhi djhi added RFR Ready For Review and removed WIP Work In Progress labels Dec 4, 2020
@fzaninotto fzaninotto merged commit 3f216c2 into master Dec 7, 2020
@fzaninotto fzaninotto deleted the support-async-validators branch December 7, 2020 10:20
@fzaninotto fzaninotto added this to the 3.10.4 milestone Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants