Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing code examples errors and typos #5517

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Editing code examples errors and typos #5517

merged 1 commit into from
Nov 12, 2020

Conversation

ValentinnDimitroff
Copy link
Contributor

No description provided.

@fzaninotto
Copy link
Member

Thanks, could you PR against master rather than next? The former is for bug/documentation fixes, the latter for new features.

@ValentinnDimitroff ValentinnDimitroff changed the base branch from next to master November 12, 2020 07:19
@ValentinnDimitroff
Copy link
Contributor Author

Oh, sure! Didn't know that's the way to proceed but will do from now on :)

@fzaninotto fzaninotto merged commit 1e2e575 into marmelab:master Nov 12, 2020
@fzaninotto fzaninotto added this to the 3.10.1 milestone Nov 12, 2020
@ValentinnDimitroff ValentinnDimitroff deleted the code-examples-fixes branch November 12, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.10.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ValentinnDimitroff @fzaninotto