Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: warning proptypes in ListToolBar component #5230

Merged
merged 1 commit into from
Sep 4, 2020
Merged

fix: warning proptypes in ListToolBar component #5230

merged 1 commit into from
Sep 4, 2020

Conversation

zyhou
Copy link
Contributor

@zyhou zyhou commented Sep 4, 2020 •
edited
Loading

When you define actions={false} in <List />, you have warning about ListToolBar proptypes.

<ListToolBar /> is create by <ListView />, I define the same props as ListView propttypes and List proptypes.

@zyhou zyhou added the RFR Ready For Review label Sep 4, 2020
@fzaninotto fzaninotto merged commit da65a25 into master Sep 4, 2020
@fzaninotto fzaninotto deleted the fix-warning-proptypes branch September 4, 2020 16:41
@fzaninotto fzaninotto added this to the 3.8.4 milestone Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.8.4
Development

Successfully merging this pull request may close these issues.
2 participants
@zyhou @fzaninotto