Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate remaining List components to TypeScript #5187

Merged
merged 9 commits into from
Aug 27, 2020
Merged

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Aug 25, 2020

Refs #4505

I took the liberty to reorganize components in subdirectories, too.

packages/ra-ui-materialui/src/list
├── datagrid
│   ├── Datagrid.tsx
│   ├── DatagridBody.tsx
│   ├── DatagridCell.spec.tsx
│   ├── DatagridCell.tsx
│   ├── DatagridHeaderCell.spec.tsx
│   ├── DatagridHeaderCell.tsx
│   ├── DatagridLoading.tsx
│   ├── DatagridRow.spec.tsx
│   ├── DatagridRow.tsx
│   ├── ExpandRowButton.tsx
│   ├── index.ts
│   └── useDatagridStyles.tsx
├── filter
│   ├── Filter.spec.tsx
│   ├── Filter.tsx
│   ├── FilterButton.spec.tsx
│   ├── FilterButton.tsx
│   ├── FilterButtonMenuItem.tsx
│   ├── FilterForm.spec.tsx
│   ├── FilterForm.tsx
│   ├── FilterFormInput.tsx
│   ├── FilterList.tsx
│   ├── FilterListItem.tsx
│   ├── FilterLiveSearch.tsx
│   └── index.ts
├── pagination
│   ├── Pagination.spec.tsx
│   ├── Pagination.tsx
│   ├── PaginationActions.spec.tsx
│   ├── PaginationActions.tsx
│   ├── PaginationLimit.tsx
│   └── index.ts
├── BulkActionsToolbar.tsx
├── BulkDeleteAction.tsx
├── Empty.tsx
├── List.spec.tsx
├── List.tsx
├── ListActions.tsx
├── ListGuesser.tsx
├── ListToolbar.tsx
├── ListView.tsx
├── Placeholder.tsx
├── SimpleList.tsx
├── SimpleListLoading.tsx
├── SingleFieldList.spec.tsx
├── SingleFieldList.tsx
├── index.ts
└── listFieldTypes.tsx

@fzaninotto fzaninotto added the RFR Ready For Review label Aug 25, 2020
@djhi djhi added this to the 3.8.3 milestone Aug 27, 2020
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -1,5 +1,5 @@
import * as React from 'react';
import Datagrid from '../list/Datagrid';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file still in JS ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's in detail - this part isn't migrated to Typecript yet (it's the last part to migrate)

@djhi djhi merged commit 8c2457a into master Aug 27, 2020
@djhi djhi deleted the list-typescript branch August 27, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants