Code

Fix pagination on bulk delete#4894

Code

Merged

JulienMattiussi merged 21 commits intomastermarmelab/react-admin:masterfrom fix-pagination-on-deletemarmelab/react-admin:fix-pagination-on-deleteCopy head branch name to clipboardJul 24, 2020

+103-25

Commits

Commits on Jul 23, 2020

• Fix pagination on bulk delete

  

  JulienMattiussi

  authored and

  Luwangel

  committed
  070de12

  Copy full SHA for 070de12

• fix tests

  

  JulienMattiussi

  authored and

  Luwangel

  committed
  8fcdfe8

  Copy full SHA for 8fcdfe8

• fix unit tests

  

  JulienMattiussi

  authored and

  Luwangel

  committed
  3d2b2ef

  Copy full SHA for 3d2b2ef

• little fixes on review

  

  JulienMattiussi

  authored and

  Luwangel

  committed
  e70acd6

  Copy full SHA for e70acd6

• refactor test (review)

  

  JulienMattiussi

  authored and

  Luwangel

  committed
  809f669

  Copy full SHA for 809f669

• Use a useMemo instead of a useCallback to compute the nb of pages in Pagination

  Luwangel

  committed
  76740a5

  Copy full SHA for 76740a5

• Fix the getNumberOrDefault method that returns the default value instead of 0 when parsing "0"

  Luwangel

  committed
  3637749

  Copy full SHA for 3637749

• Compute the total pages for a list and pass it to the list context

  Luwangel

  committed
  e6357bc

  Copy full SHA for e6357bc

• Set the page to the last existing page in the useListController if querying a page out of bounds

  Luwangel

  committed
  0774a43

  Copy full SHA for 0774a43

• Use totalPages in Pagination

  Luwangel

  committed
  8850de6

  Copy full SHA for 8850de6

• Remove console.log

  Luwangel

  committed
  fa8ec88

  Copy full SHA for fa8ec88

• Sanitize the total pages prop in the ListView

  Luwangel

  committed
  e3c9cf4

  Copy full SHA for e3c9cf4

• Fix total page out of bound limit for material ui in Pagination

  Luwangel

  committed
  f08f96f

  Copy full SHA for f08f96f

• Fix a problem with Pagination when trying to pass negative pages through the URL

  Luwangel

  committed
  9e499ad

  Copy full SHA for 9e499ad

• Write a new test for negative pages

  Luwangel

  committed
  956f627

  Copy full SHA for 956f627

• Fix the ListControllerProps TypeScript type

  Luwangel

  committed
  3d33bfb

  Copy full SHA for 3d33bfb

Commits on Jul 24, 2020

• Make the total pages optionnal in TypeScript types

  Luwangel

  committed
  446ed85

  Copy full SHA for 446ed85

• Count the total pages everywhere and not make it optional

  Luwangel

  committed
  8116dbb

  Copy full SHA for 8116dbb

• Remove the totalPages from contexts because it could be recomputed using perPage and total

  Luwangel

  committed
  7c75b30

  Copy full SHA for 7c75b30

• Apply reviews

  Luwangel

  committed
  6e46f41

  Copy full SHA for 6e46f41

• Fix useEffect in useListController

  Luwangel

  committed
  8223ab0

  Copy full SHA for 8223ab0