Migrate AppBar to tsx #4873
Migrate AppBar to tsx #4873
Conversation
| @@ -147,17 +150,19 @@ const AppBar = props => { | |||
| ); | |||
| }; | |||
|
|
|||
| interface Props { | |||
There was a problem hiding this comment.
Hello @josephktcheung can you please add title property as TitleComponent from ra-core
There was a problem hiding this comment.
Hi @MohammedFaragallah thanks for the review. Good catch on this, from what I understand AppBar no longer uses title prop, I guess the reason why it's not removed is because we inject title prop to AppBar in Layout. If we don't de-structure AppBar props here, we may pass a wrong title type to material-ui's AppBar by spreading the rest prop here
Therefore, I question the need of passing title prop when we cloneElement in https://github.com/marmelab/react-admin/blob/next/packages/ra-ui-materialui/src/layout/Layout.js#L124. I think title prop can be removed from AppBar which we did previously a9e4e0d but somehow reverted back by @fzaninotto 0f1b404#diff-bbb6c2d0f8bfb7588ebadf3e64ed2e57 perhaps because of the reason I mention above.
@fzaninotto please confirm if title prop is still relevant for AppBar or is it a legacy code?
Migrate AppBar to tsx #4505