Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix react imports #4864

Merged
merged 1 commit into from
May 27, 2020
Merged

Fix react imports #4864

merged 1 commit into from
May 27, 2020

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented May 27, 2020

Fix #4857

fzaninotto
fzaninotto approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@fzaninotto fzaninotto merged commit a0422d9 into master May 27, 2020
@fzaninotto fzaninotto deleted the fix-react-imports branch May 27, 2020 14:19
@fzaninotto fzaninotto added this to the 3.5.4 milestone May 27, 2020
@deksden
Copy link

deksden commented May 29, 2020

Small note: some md files in code samples have code with double quotes in import, like import * as React from "react";. All code actually have single-quoted imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.5
Development

Successfully merging this pull request may close these issues.

Fix React Imports
3 participants
@djhi @deksden @fzaninotto