Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add a link to Clipboard List Field third-party package #4659

Merged
merged 2 commits into from
Apr 16, 2020
Merged

[Doc] Add a link to Clipboard List Field third-party package #4659

merged 2 commits into from
Apr 16, 2020

Conversation

OoDeLally
Copy link
Contributor

Here is a copy-to-clipboard field.
https://github.com/OoDeLally/react-admin-clipboard-list-field
Being new to both React Admin and MaterialUI, I would be grateful if anyone can review my component and suggest improvements.

@OoDeLally OoDeLally changed the title Added react-admin-clipboard-list-field to Fields.md Component: Clipboard List Field Apr 7, 2020
@@ -894,6 +894,14 @@ PriceField.defaultProps = {
```
{% endraw %}


## Third-Party Components
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add it to the Ecosystem documentation instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I moved all third-part links to Ecosystem, to be consistent.
This could be part of this PR or another one, your choice.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So your last changes makes me realize that what I asked you is wrong, sorry. The third party field should be added to the Fields doc, and the Ecosystem should be updated to add a link to the third party fields.

@OoDeLally
Copy link
Contributor Author

Here you go.

@fzaninotto fzaninotto changed the title Component: Clipboard List Field [Doc] Add a link to Clipboard List Field third-party package Apr 16, 2020
@fzaninotto fzaninotto merged commit 1ed1b61 into marmelab:next Apr 16, 2020
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto modified the milestones: 3.4.2, 3.5.0 Apr 16, 2020
@OoDeLally OoDeLally deleted the react-admin-clipboard-list-field branch April 16, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants