Make useInput hook return child's input.value when parent's enhanced … #4638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prasanna214
force-pushed
the
4203-initial-value-render-issue
branch
from
827db44 to
246906b
Compare
…input.value is undefined. Closes marmelab#4203 Issue was caused by useField hook of final-form returning defaultValue of field as undefined (when it is not yet available in state) while enhancing the parent input. useInput hook of react-admin is considering same enhanced input with value undefined while rendering the children.
prasanna214
force-pushed
the
4203-initial-value-render-issue
branch
from
246906b to
e63fc7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…input.value is undefined.
Closes #4203
Issue was caused by useField hook of react-final-form returning defaultValue of field as undefined (when it is not yet available in state) while enhancing the parent input.
useInput hook of react-admin is considering same enhanced input with value undefined while rendering the children.