Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert ArrayField component to function component. #4536

Merged
merged 22 commits into from
May 7, 2020
Merged

Convert ArrayField component to function component. #4536

merged 22 commits into from
May 7, 2020

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Mar 15, 2020

No description provided.

ThieryMichel
ThieryMichel requested changes Mar 17, 2020
View reviewed changes
packages/ra-ui-materialui/src/field/ArrayField.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/field/ArrayField.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/field/ArrayField.tsx Show resolved Hide resolved
packages/ra-ui-materialui/src/field/ArrayField.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/field/ArrayField.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/field/ArrayField.tsx Outdated Show resolved Hide resolved
@WiXSL WiXSL requested a review from ThieryMichel March 17, 2020 17:34
@WiXSL WiXSL requested a review from fzaninotto April 30, 2020 16:11
@WiXSL WiXSL requested a review from fzaninotto April 30, 2020 16:51
@WiXSL WiXSL force-pushed the array-field-fc branch from a4c8de4 to 0d11f31 Compare May 6, 2020 01:30
asvarcas added 18 commits May 7, 2020 09:58
@WiXSL WiXSL force-pushed the array-field-fc branch from bb2837e to dde82ec Compare May 7, 2020 13:00
@WiXSL WiXSL requested a review from fzaninotto May 7, 2020 13:16
fzaninotto
fzaninotto requested changes May 7, 2020
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

packages/ra-ui-materialui/src/field/ArrayField.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/field/ArrayField.tsx Outdated Show resolved Hide resolved
@WiXSL WiXSL requested a review from fzaninotto May 7, 2020 14:22
@WiXSL WiXSL requested a review from fzaninotto May 7, 2020 15:20
@fzaninotto fzaninotto merged commit d8804ef into marmelab:next May 7, 2020
@fzaninotto
Copy link
Member

Awesome, thanks a lot for your patience!

@fzaninotto fzaninotto added this to the 3.6.0 milestone May 7, 2020
@WiXSL WiXSL deleted the array-field-fc branch May 7, 2020 15:56
@sebitoelcheater
Copy link

sebitoelcheater commented Jun 8, 2020 •
edited
Loading

I get an error using SingleFieldList inside ArrayField. This PR seems to be causing the error.

<ArrayField source="statements">
  <SingleFieldList>
    <ChipField source="name"/>
  </SingleFieldList>
</ArrayField>

throws

TypeError: Cannot read property 'map' of undefined

@djhi
Copy link
Collaborator

djhi commented Jun 8, 2020

@sebitoelcheater Can you please open a proper issue?

@sebitoelcheater sebitoelcheater mentioned this pull request Jun 8, 2020
Closed
@smeng9 smeng9 mentioned this pull request Jun 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@ThieryMichel ThieryMichel Awaiting requested review from ThieryMichel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@WiXSL @fzaninotto @sebitoelcheater @djhi @ThieryMichel