Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination buttons are in the wrong direction in RTL languages #4496

Merged
merged 3 commits into from
Mar 10, 2020

Conversation

alikazemkhanloo
Copy link
Contributor

this PR will change the chevron direction in PaginationActrions for RTL, as in the gist suggested in #3348. But using hooks to get the theme.

@fzaninotto
Copy link
Member

I'm not sure I understand. Can you please explain the problem, and paste a screenshot to show the result of your change?

@kopax
Copy link
Contributor

kopax commented Mar 10, 2020

RTL means right to left, such as arabic language.
image

@fzaninotto
Copy link
Member

I know that, I just don't understand what the problem is with pagination in RTL languages.

@alikazemkhanloo
Copy link
Contributor Author

this is what it looks like in RTL:

Screenshot from 2020-03-10 12-55-29---

@JulienMattiussi
Copy link
Contributor

@alikazemkhanloo
I think your reverted ChevronLeft and ChevronRight in your PR, because you keep the current behaviour when direction === rtl.

@alikazemkhanloo
Copy link
Contributor Author

@JulienMattiussi Thanks.

@fzaninotto fzaninotto changed the title change chevronDirection in RTL Fix pagination buttons are in the wrong direction in RTL languages Mar 10, 2020
@fzaninotto fzaninotto merged commit bb82919 into marmelab:master Mar 10, 2020
@fzaninotto
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants