Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build of ra-input-rich-text #4455

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Conversation

teyc
Copy link
Contributor

@teyc teyc commented Feb 27, 2020

Hi there,

Thank you for such a nice library!

I don't know too much about lerna but I learnt that for the build to work I
need to add a dependency from ra-input-rich-text to ra-ui-materialui.

I don't know if this is exactly the right thing to do, but I'd appreciate any feed back.

Regards

npm run build fails on a fresh checkout

Cannot find module 'ra-ui-materialui when building ra-input-rich-text

> [email protected] build C:\dev\oss\react-admin\packages\ra-input-rich-text
> yarn run build-cjs && yarn run build-esm

yarn run v1.15.2
$ rimraf ./lib && tsc
src/index.tsx(11,33): error TS2307: Cannot find module 'ra-ui-materialui'.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

    at C:\dev\OSS\react-admin\node_modules\lerna\node_modules\execa\index.js:236:11
    at processTicksAndRejections (internal/process/task_queues.js:97:5) {
  code: 2,
  killed: false,
  stdout: '\n' +
    '> [email protected] build C:\\dev\\oss\\react-admin\\packages\\ra-input-rich-text\n' +
    '> yarn run build-cjs && yarn run build-esm\n' +
    '\n' +
    'yarn run v1.15.2\n' +
    '$ rimraf ./lib && tsc\n' +
    "src/index.tsx(11,33): error TS2307: Cannot find module 'ra-ui-materialui'.\r\n" +
    'info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.\n',
  stderr: 'error Command failed with exit code 2.\n' +
    'npm ERR! code ELIFECYCLE\n' +
    'npm ERR! errno 2\n' +
    'npm ERR! [email protected] build: `yarn run build-cjs && yarn run build-esm`\n' +
    'npm ERR! Exit status 2\n' +
    'npm ERR! \n' +
    'npm ERR! Failed at the [email protected] build script.\n' +
    'npm ERR! This is probably not a problem with npm. There is likely additional logging output above.\n' +
    '\n' +
    'npm ERR! A complete log of this run can be found in:\n' +
    'npm ERR!     C:\\Users\\teyc\\AppData\\Roaming\\npm-cache\\_logs\\2020-02-27T10_31_20_950Z-debug.log\n',

src/index.tsx(11,33): error TS2307:
Cannot find module 'ra-ui-materialui'.

src/index.tsx(11,33): error TS2307:
Cannot find module 'ra-ui-materialui'.
@fzaninotto fzaninotto changed the title Fix lerna build Fix build of ra-input-rich-text Mar 10, 2020
@fzaninotto fzaninotto changed the base branch from next to master March 10, 2020 13:21
@fzaninotto fzaninotto merged commit 3320cd7 into marmelab:master Mar 10, 2020
@fzaninotto
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants