Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Migrate tests to react-testing-library #4446

Merged
merged 13 commits into from
Mar 3, 2020
Merged

[RFR] Migrate tests to react-testing-library #4446

merged 13 commits into from
Mar 3, 2020

Conversation

m4theushw
Copy link
Contributor

@m4theushw m4theushw commented Feb 26, 2020 •
edited
Loading

This PR migrates to react-testing-library all test cases that still use enzyme.

TODO

  • DataGridCell
  • SingleFieldList
  • CloneButton
  • PaginationActions
  • RoutesWithLayout
  • FormDataConsumerView
  • FormField
  • SimpleShowLayout
  • FunctionField
  • ReferenceManyField
  • ReferenceArrayInput
  • Responsive

fzaninotto
fzaninotto requested changes Feb 27, 2020
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please switch from assert to expect at the same time? That would avoid us to do another round of maintenance on the same files.

@m4theushw
Copy link
Contributor Author

@fzaninotto Sure.

@m4theushw m4theushw changed the title [WIP] Migrate tests to react-testing-library [RFR] Migrate tests to react-testing-library Feb 28, 2020
@m4theushw m4theushw requested a review from fzaninotto February 28, 2020 03:42
@fzaninotto fzaninotto merged commit a282acd into marmelab:next Mar 3, 2020
@fzaninotto
Copy link
Member

Awesome! Thanks a lot for your contribution.

@fzaninotto fzaninotto added this to the 3.3.0 milestone Mar 3, 2020
This was referenced Apr 10, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@m4theushw @fzaninotto