Throw an error when useGetOne is called for an undefined resource #4430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luwangel
approved these changes
Feb 19, 2020
fzaninotto
force-pushed
the
usegetone-error-in-no-ressource
branch
from
3844196 to
4b01ee6
Compare
|
This caused a regression in 3.6.0, which should be fixed by #4990 (released in 3.6.3). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
useQueryworks even without a<Resource>because it doesn't rely on the Redux store. However, developers may want to use the more specialized hooks, likeuseGetOne(). These only work if there is a<Resource>, but for now if there is no resource the hook returns null - which is not a good developer experience.Solution
This change throws an error in case of missing Resource for useGetOne. It's a start. It's a bit harder to do for other data Provider hooks, so let's start with this baby step/