Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Dashboard demo components to TypeScript #4415

Merged
merged 22 commits into from
Feb 14, 2020
Merged

Migrate Dashboard demo components to TypeScript #4415

merged 22 commits into from
Feb 14, 2020

Conversation

developerium
Copy link
Contributor

@developerium developerium commented Feb 12, 2020 •
edited
Loading

Hi guys

I've just refactored a couple of components to typescript. Please check it out and let me know if I'm moving in the right direction.

If I guess correctly, all reusable component types should go inside examples/demo/src/types.ts right?

@fzaninotto
Copy link
Member

Looking good, and yes, reusable types should go to a central types.ts file, just like in ra-core.

Could you add a checklist to your issue description, so that we know which components you intend to merge, and when the PR is ready to be merged?

@developerium
Copy link
Contributor Author

developerium commented Feb 12, 2020 •
edited
Loading

I'm not sure how to make a checklist, but I want to refactor all components in examples/demo/src/dashboard

kheradmand added 11 commits February 12, 2020 13:30
@fzaninotto
Copy link
Member

Then please add a comment when you think you're done.

@developerium
Copy link
Contributor Author

All done!
Please check it out

@fzaninotto fzaninotto changed the title Refactor demo components to typescript Migrate Dashboard demo components to TypeScript Feb 14, 2020
@fzaninotto fzaninotto merged commit 149a439 into marmelab:master Feb 14, 2020
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 3.2.3 milestone Feb 14, 2020
@developerium
Copy link
Contributor Author

No problem 😄

@developerium developerium deleted the demo_typescript_components branch February 15, 2020 05:45
This was referenced Apr 10, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@developerium @fzaninotto