Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve @material-ui includes. #4265

Merged
merged 3 commits into from
Jan 9, 2020
Merged

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Jan 8, 2020

Refs #4253

@fzaninotto
Copy link
Member

We won't merge the changes to the @material-ui/core imports. Our developer experience is also important, and the "one line per component import" is just too cumbersome. Besides, the performance issue only concerns icons. So please just change the 2 instances of @material-ui/icons import.

@WiXSL WiXSL force-pushed the patch-mui-imports branch from 54ce5b2 to b1aab7a Compare January 9, 2020 13:13
@WiXSL
Copy link
Contributor Author

WiXSL commented Jan 9, 2020

Ok.
At least could I include one liners like:

- import { useMediaQuery } from '@material-ui/core';
+ import useMediaQuery from '@material-ui/core/useMediaQuery';

- import { makeStyles } from '@material-ui/core';
+ import { makeStyles } from '@material-ui/core/styles';

@fzaninotto
Copy link
Member

No thanks, I'll merge it as is. I don't want to introduce two syntax for importing from @material-ui/core.

@fzaninotto fzaninotto merged commit af1e0b3 into marmelab:master Jan 9, 2020
@fzaninotto fzaninotto added this to the 3.1.2 milestone Jan 9, 2020
@fzaninotto
Copy link
Member

Thanks!

@WiXSL WiXSL deleted the patch-mui-imports branch January 9, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants