Fix cache timeout reload list #4261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThieryMichel
added
WIP
fzaninotto
approved these changes
Jan 9, 2020
|
Thanks! |
This was referenced Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4245, #3727, #3227
To fix the issue, I add to change the reducer so as to never remove data not impacted by an action even if it is outdated.
For example a GET_ONE would update the other items of the same resources removing all outdated value.
Same for GET_REFERENCE_MANY that would replace all the previous items.
The issue is that if we display an edit form along the list.
Then by opening this edit form (that trigger a GET_ONE) Then this GET_ONE would remove all items except the edited one as well as all reference linket to these items
As an added bonus, now if we are on an edit page and return on the list after the cache has expired: The old list will first be displayed, before fetching the new data and if the data did not change, we get no rerender. As opposed to displaying the list with only the edited item, before reloading the rest.